Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include hoursBeforeEarlyXpDecay in response #1156

Merged

Conversation

GabrielCWT
Copy link
Contributor

@GabrielCWT GabrielCWT commented Aug 21, 2024

Includes hoursBeforeEarlyXpDecay in return response. This is to allow the frontend to know when full bonus xp ends.
Frontend PR: source-academy/frontend#3025

@coveralls
Copy link

coveralls commented Aug 21, 2024

Coverage Status

coverage: 94.356% (+0.001%) from 94.355%
when pulling 7330aac on GabrielCWT:feat/show-bonus-xp-end-date
into 9723ec3 on source-academy:master.

@GabrielCWT GabrielCWT self-assigned this Aug 22, 2024
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) August 23, 2024 03:58
@RichDom2185 RichDom2185 merged commit fbc8e15 into source-academy:master Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants